[mcp] Refactor #33085
Merged
[mcp] Refactor #33085
+243
−214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 1, 2025
Merged
Merged
Merged
github-actions
bot
added
the
React Core Team
jorge-cab
approved these changes
May 2, 2025
| 'window.__RESULT__ !== undefined && (window.__RESULT__.renderTime !== null || window.__RESULT__.error !== null)', | ||
| ); | ||
| // ui chaos monkey | ||
| await page.waitForFunction(`window.__RESULT__ !== undefined && (function() { |
There was a problem hiding this comment.
nit: I don't think we need to check for window.RESULT !== undefined again here
poteto
added a commit
that referenced
this pull request
May 2, 2025
Since we use esbuild we need to correctly move dependencies that are required at runtime into `dependencies` and other packages that are only used in development in to `devDependencies`. This ensures the correct packages are included in the build. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/33101). * #33085 * #33084 * #33083 * #33082 * __->__ #33101
poteto
added a commit
that referenced
this pull request
May 2, 2025
Adds typescript support. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/33082). * #33085 * #33084 * #33083 * __->__ #33082 * #33101
poteto
added a commit
that referenced
this pull request
May 2, 2025
Moves to a tools directory. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/33083). * #33085 * #33084 * __->__ #33083
poteto
added a commit
that referenced
this pull request
May 2, 2025
Some tweaks to the prompt to provide more context on how to use them. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/33084). * #33085 * __->__ #33084 * #33083
Just some cleanup. Mainly, we now take the number of iterations as an argument. Everything else is just code movement and small tweaks.
This was referenced May 12, 2025
This was referenced May 19, 2025
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some cleanup. Mainly, we now take the number of iterations as an argument. Everything else is just code movement and small tweaks.